[PATCH] D151024: [llvm-exegesis] Add memory annotation parsing

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/SnippetFile.h:32
+readSnippets(const LLVMState &State, StringRef Filename,
+             BenchmarkRunner::ExecutionModeE ExecutionMode);
 
----------------
>From a design perspective I don't think `readSnippets` should know about `ExecutionMode`. The parser just parses, let's check in that there are no memory mappings in the `BenchmarkCode` when using it (e.g. in `main`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151024/new/

https://reviews.llvm.org/D151024