[PATCH] D153050: [mlir][ArmSME] Insert intrinsics to enable/disable ZA

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added inline comments.


================
Comment at: mlir/test/Dialect/ArmSME/enable-arm-za.mlir:1
+// RUN: mlir-opt %s -enable-arm-streaming=enable-za -convert-vector-to-llvm="enable-arm-sme" | FileCheck %s
+
----------------
c-rhodes wrote:
> awarzynski wrote:
> > Could you add another RUN line without `enable-za` and verify that there's no `asm_sme.intr.za.{enable|disable}`?
> > 
> > It would also be good to test without the `-enable-arm-streaming` pass.
> > Could you add another RUN line without `enable-za` and verify that there's no `asm_sme.intr.za.{enable|disable}`?
> 
> Done
> 
> > 
> > It would also be good to test without the `-enable-arm-streaming` pass.
> 
> I misunderstood what you mean here somehow, will update again to add this 😄 
> I misunderstood what you mean here somehow, will update again to add this 😄

Ah, I meant a test in which the input already contains `arm_za`. Added by hand rather then a compiler :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153050/new/

https://reviews.llvm.org/D153050