[PATCH] D151023: [llvm-exegesis] Add Target Memory Utility Functions

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/X86/Target.cpp:1036
+  generateGetInstructionPointer(X86::R8, GeneratedCode);
+  // Load in the size of the snippet to %RDI from from the argument register.
+  GeneratedCode.push_back(MCInstBuilder(X86::MOV64rr)
----------------
[nit] Use `RDI` for consistency with the rest of the file


================
Comment at: llvm/tools/llvm-exegesis/lib/X86/Target.cpp:1055
+  GeneratedCode.push_back(loadImmediate(
+      X86::RSI, 64, APInt(64, 0x0000800000000000 - getpagesize())));
+  GeneratedCode.push_back(MCInstBuilder(X86::SUB64rr)
----------------
Please create a constant for this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151023/new/

https://reviews.llvm.org/D151023