[PATCH] D151022: [llvm-exegesis] Introduce SubprocessMemory Utility Class

[Aiden Grossman via Phabricator via llvm-commits]

aidengrossman added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/SubprocessMemory.h:30
+
+static constexpr const size_t AuxiliaryMemoryOffset = 1;
+static constexpr const size_t AuxiliaryMemorySize = 4096;
----------------
courbet wrote:
> we're in a header, the `static` here is weird. Did you mean to put this in a class definition, or in the `cpp` file ?
Thanks for the catch! Moved it into the class as it's used in multiple files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151022/new/

https://reviews.llvm.org/D151022