[PATCH] D153104: [DAG] Unroll and expand illegal result of LDEXP and POWI instead of widen.

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 16 00:57:25 PDT 2023


pengfei added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:4090-4095
+    if (unrollExpandedOp())
+      break;
+    // If the target has custom/legal support for the scalar FP intrinsic ops
+    // (they are probably not destined to become libcalls), then widen those
+    // like any other unary ops.
+    [[fallthrough]];
----------------
How about change like this?

fallthrough to `WidenVecRes_EXTEND_VECTOR_INREG` seems different from the old code that calling `WidenVecRes_ExpOp`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153104/new/

https://reviews.llvm.org/D153104



More information about the llvm-commits mailing list