[PATCH] D151022: [llvm-exegesis] Introduce SubprocessMemory Utility Class

[Clement Courbet via Phabricator via llvm-commits]

courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/tools/llvm-exegesis/lib/SubprocessMemory.cpp:74
+      return make_error<Failure>(
+          "Unmappng a memory definition in the parent failed: " +
+          Twine(strerror(errno)));
----------------
typo


================
Comment at: llvm/tools/llvm-exegesis/lib/SubprocessMemory.h:30
+
+static constexpr const size_t AuxiliaryMemoryOffset = 1;
+static constexpr const size_t AuxiliaryMemorySize = 4096;
----------------
we're in a header, the `static` here is weird. Did you mean to put this in a class definition, or in the `cpp` file ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151022/new/

https://reviews.llvm.org/D151022