[PATCH] D93838: [SCCP] Add Function Specialization pass

[Nuno Lopes via Phabricator via llvm-commits]

nlopes added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/FunctionSpecialization.cpp:135
+    auto *Const = IV.isConstant() ? Solver.getConstant(IV)
+                                  : UndefValue::get(V->getType());
+    V->replaceAllUsesWith(Const);
----------------
Can't this be poison?
If this is just a placeholder for unreachable code, then poison is sufficient.

We're trying to remove undef, so we appreciate if no more uses of undef get added to the codebase.
Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93838/new/

https://reviews.llvm.org/D93838