[PATCH] D153090: [OCaml] Rename link_modules' to link_modules

[Alan via Phabricator via llvm-commits]

alan created this revision.
Herald added a project: All.
alan requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Commit 434e956 renamed link_modules to link_modules' for unclear reasons.
Based on the commit's diff, the author possibly intended to have two
functions, link_modules to bind to LLVMLinkModules and link_modules' to
bind to LLVMLinkModules2. However, there is only one function. link_modules'
appears in LLVM 3.8 onwards.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D153090

Files:
  llvm/bindings/ocaml/linker/llvm_linker.ml
  llvm/bindings/ocaml/linker/llvm_linker.mli
  llvm/test/Bindings/OCaml/linker.ml


Index: llvm/test/Bindings/OCaml/linker.ml
===================================================================
--- llvm/test/Bindings/OCaml/linker.ml
+++ llvm/test/Bindings/OCaml/linker.ml
@@ -43,18 +43,18 @@
 
   let m1 = make_module "one"
   and m2 = make_module "two" in
-  link_modules' m1 m2;
+  link_modules m1 m2;
   dispose_module m1;
 
   let m1 = make_module "one"
   and m2 = make_module "two" in
-  link_modules' m1 m2;
+  link_modules m1 m2;
   dispose_module m1;
 
   let m1 = make_module "one"
   and m2 = make_module "one" in
   try
-    link_modules' m1 m2;
+    link_modules m1 m2;
     failwith "must raise"
   with Error _ ->
     dispose_module m1
Index: llvm/bindings/ocaml/linker/llvm_linker.mli
===================================================================
--- llvm/bindings/ocaml/linker/llvm_linker.mli
+++ llvm/bindings/ocaml/linker/llvm_linker.mli
@@ -13,6 +13,6 @@
 
 exception Error of string
 
-(** [link_modules' dst src] links [src] into [dst], raising [Error]
+(** [link_modules dst src] links [src] into [dst], raising [Error]
     if the linking fails. The src module is destroyed. *)
-val link_modules' : Llvm.llmodule -> Llvm.llmodule -> unit
\ No newline at end of file
+val link_modules : Llvm.llmodule -> Llvm.llmodule -> unit
Index: llvm/bindings/ocaml/linker/llvm_linker.ml
===================================================================
--- llvm/bindings/ocaml/linker/llvm_linker.ml
+++ llvm/bindings/ocaml/linker/llvm_linker.ml
@@ -10,5 +10,5 @@
 
 let () = Callback.register_exception "Llvm_linker.Error" (Error "")
 
-external link_modules' : Llvm.llmodule -> Llvm.llmodule -> unit
-                       = "llvm_link_modules"
+external link_modules : Llvm.llmodule -> Llvm.llmodule -> unit
+                      = "llvm_link_modules"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153090.531960.patch
Type: text/x-patch
Size: 1792 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230616/acb102a4/attachment-0001.bin>