[PATCH] D153084: AMDGPU: Partially fix not respecting dynamic denormal mode

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 15:52:10 PDT 2023


arsenm created this revision.
arsenm added reviewers: AMDGPU, rampitec, foad, Pierre-vh, cdevadas.
Herald added subscribers: StephenFan, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

The most notable issue was producing v_mad_f32 in functions with the
dynamic mode, since it just ignores the mode. fdiv lowering is still
somewhat broken because it involves a mode switch and we need to query
the original mode.


https://reviews.llvm.org/D153084

Files:
  llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
  llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
  llvm/lib/Target/AMDGPU/AMDGPUInstructions.td
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
  llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/lib/Target/AMDGPU/SIModeRegisterDefaults.h
  llvm/test/CodeGen/AMDGPU/GlobalISel/combine-fma-unmerge-values.mir
  llvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-fdiv.ll
  llvm/test/CodeGen/AMDGPU/fdiv.ll
  llvm/test/CodeGen/AMDGPU/llvm.exp.ll
  llvm/test/CodeGen/AMDGPU/llvm.log.ll
  llvm/test/CodeGen/AMDGPU/llvm.log10.ll
  llvm/test/CodeGen/AMDGPU/v_mac.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153084.531929.patch
Type: text/x-patch
Size: 177475 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230615/a1886c8a/attachment-0001.bin>


More information about the llvm-commits mailing list