[PATCH] D152841: Prevent out of range fixup encoding on AArch64

Daniel Hoekwater via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 15:23:30 PDT 2023


dhoekwater added a comment.

In D152841#4423980 <https://reviews.llvm.org/D152841#4423980>, @efriedma wrote:

> I saw the 4GB issue with other relocations.  Actually, I didn't even try adrp.  I don't think we ever use this codepath for adrp.

Oh, interesting! I can't recreate that behavior by manually setting large offsets in this test. What assembly did you use to expose that?

We do use this codepath for adrp, but I guess only on Windows. `case AArch64::fixup_aarch64_pcrel_adrp_imm21` handles the fixup, and it's tested in `llvm/test/MC/AArch64/fixup-out-of-range.s`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152841/new/

https://reviews.llvm.org/D152841



More information about the llvm-commits mailing list