[llvm] d620ba0 - [MC] Remove unneeded isUndefined() for isSymbolRefDifferenceFullyResolved. NFC

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 15:07:08 PDT 2023


Author: Fangrui Song
Date: 2023-06-15T15:07:04-07:00
New Revision: d620ba0344c719da51b6067975439ed84024b1ac

URL: https://github.com/llvm/llvm-project/commit/d620ba0344c719da51b6067975439ed84024b1ac
DIFF: https://github.com/llvm/llvm-project/commit/d620ba0344c719da51b6067975439ed84024b1ac.diff

LOG: [MC] Remove unneeded isUndefined() for isSymbolRefDifferenceFullyResolved. NFC

The only caller `AttemptToFoldSymbolOffsetDifference` has performed the same
checks.

Added: 
    

Modified: 
    llvm/lib/MC/MCObjectWriter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/MC/MCObjectWriter.cpp b/llvm/lib/MC/MCObjectWriter.cpp
index 89ff5800da5bc..559aff130d880 100644
--- a/llvm/lib/MC/MCObjectWriter.cpp
+++ b/llvm/lib/MC/MCObjectWriter.cpp
@@ -28,9 +28,7 @@ bool MCObjectWriter::isSymbolRefDifferenceFullyResolved(
 
   const MCSymbol &SA = A->getSymbol();
   const MCSymbol &SB = B->getSymbol();
-  if (SA.isUndefined() || SB.isUndefined())
-    return false;
-
+  assert(!SA.isUndefined() && !SB.isUndefined());
   if (!SA.getFragment() || !SB.getFragment())
     return false;
 


        


More information about the llvm-commits mailing list