[PATCH] D152940: [RISCV] Make all vector binops use the _TU pseudo form

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 12:18:23 PDT 2023


reames requested review of this revision.
reames added a comment.

In D152940#4425231 <https://reviews.llvm.org/D152940#4425231>, @reames wrote:

> Noticed this set of _TUs is one of the ones *without* a policy operand, need to fix that first.

Actually, no, I don't.  This patch is fine.  At the moment, we're only using _TU for either "tail undisturbed" or "tail undefined".  Given that, the lack of the policy flag isn't a problem - the pass through operand tells us which is which.  It will be once we start forming "tail agnostic" instances, but that's another patch, and I can group the policy operand addition with the consumer who needs it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152940/new/

https://reviews.llvm.org/D152940



More information about the llvm-commits mailing list