[PATCH] D150384: [CodeGenPrepare] Fix for using outdated/corrupt LoopInfo

Thu Jun 15 11:57:39 PDT 2023

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:636
+#ifndef NDEBUG
+  if (MadeChange && VerifyLoopInfo)
+    LI->verify(getDT(F));
----------------
Weird indentation

================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:6964
   BasicBlock::iterator SplitPt = ++(BasicBlock::iterator(LastSI));
   BasicBlock *EndBlock = StartBlock->splitBasicBlock(SplitPt, "select.end");
   if (IsHugeFunc)
----------------
I think we have a SplitBasicBlock utility that handles DT/LI automatically, but I don't want to make any complex refactorings block this.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150384/new/

https://reviews.llvm.org/D150384