[PATCH] D143018: [DAGCombiner][NFC] Factor out ByteProvider

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:8829
+    assert(P.hasSrc() && "Must be a memory byte provider");
+    assert(isa<LoadSDNode>(P.Src.value()));
+    LoadSDNode *Load = cast<LoadSDNode>(P.Src.value());
----------------
(style) missing assert message (or merge the 2 asserts):
```
assert(P.hasSrc() && isa<LoadSDNode>(P.Src.value()) && "Must be a memory byte provider");
```


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:8830
+    assert(isa<LoadSDNode>(P.Src.value()));
+    LoadSDNode *Load = cast<LoadSDNode>(P.Src.value());
+
----------------
auto*


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:8867
+    assert(P->hasSrc() && "provenance should either be memory or zero");
+    assert(isa<LoadSDNode>(P->Src.value()));
+    LoadSDNode *L = cast<LoadSDNode>(P->Src.value());
----------------
(style) missing assert message (or merge the 2 asserts):
```
assert(P->hasSrc() && isa<LoadSDNode>(P->Src.value()) && "provenance should either be memory or zero");
```


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:8868
+    assert(isa<LoadSDNode>(P->Src.value()));
+    LoadSDNode *L = cast<LoadSDNode>(P->Src.value());
 
----------------
auto*


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:8949
     return SDValue();
-  LoadSDNode *FirstLoad = FirstByteProvider->Load;
+  assert(isa<LoadSDNode>(FirstByteProvider->Src.value()));
+  LoadSDNode *FirstLoad = cast<LoadSDNode>(FirstByteProvider->Src.value());
----------------
this assert isn't necessary as the cast<> will also assert (same for the other above which I suggested merging with the other assert....)


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:8950
+  assert(isa<LoadSDNode>(FirstByteProvider->Src.value()));
+  LoadSDNode *FirstLoad = cast<LoadSDNode>(FirstByteProvider->Src.value());
 
----------------
auto *


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143018/new/

https://reviews.llvm.org/D143018