[PATCH] D153051: [Support][Unix] create_directory should fail if the path is not directory

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 10:09:04 PDT 2023


steven_wu added a comment.

Two comments on this patch:

- I don't know what is the behavior on windows. From docs, it should have the correct behavior, but probably not returning the same error_code.
- It currently returns `EEXIST` in such case (at least on macOS). I am not sure if other unix/linux returns the same error, or it returns `ENOTDIR`? Pre-commit test might give some answer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153051/new/

https://reviews.llvm.org/D153051



More information about the llvm-commits mailing list