[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

Thu Jun 15 09:39:23 PDT 2023

jrtc27 added a comment.

In D153008#4425238 <https://reviews.llvm.org/D153008#4425238>, @abel-bernabeu wrote:

> In D153008#4424821 <https://reviews.llvm.org/D153008#4424821>, @jrtc27 wrote:
>
>> Clang tests should not compile to asm. You want an IR test.
>
> Jessica, are there any exceptions for tests is under CodeGen/RISCV intended to exercise the assembly parser?
>
> I have just written a test that reproduces the way I manually test the feature.

No. You can test the assembly parser just as easily from IR.

I'll also note that your assembly isn't particularly minimal, which it should be, unless the `add zero, %[dst], %[dst]` lines are doing something I'm not aware of?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153008/new/

https://reviews.llvm.org/D153008