[PATCH] D153020: [X86] Fix callee side of receiving byval args on the stack

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 09:18:06 PDT 2023


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

I checked the code and as I understand it, byval has no effect on the first four pointer arguments, those are passed in the 4 register parameters indirectly. After that, byval works normally as it does for i686 and other platforms. The argument is placed on the stack and it can be materialized.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153020/new/

https://reviews.llvm.org/D153020



More information about the llvm-commits mailing list