[PATCH] D151187: [doc] Add casting style preference to coding standards
Sergei Barannikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 15 07:38:05 PDT 2023
barannikov88 added a comment.
In D151187#4424114 <https://reviews.llvm.org/D151187#4424114>, @jhenderson wrote:
> (If the issue is more that you'd be forced to use a static_cast initially and then the transition to a class results in an unnecessary static_cast, I think it would be fine to argue that you're ignoring the style guide because a pending change will work better, and I think that rule applies for all parts of the style guide).
Sounds fine to me, although I read it as "ignoring the style guide is allowed if you can convince the reviewer".
OK then.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151187/new/
https://reviews.llvm.org/D151187
More information about the llvm-commits
mailing list