[PATCH] D152957: ValueTracking: Fix nan result handling for fmul

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4785
+    if (!F)
+      break;
+
----------------
foad wrote:
> Would it be worth changing isKnownNeverLogicalZero to take a `Function *` and handle the nullptr case conservatively?
I was more looking into removing the allow-unparented instructions case since SimplifyInstruction now requires parents


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152957/new/

https://reviews.llvm.org/D152957