[PATCH] D152961: [RISCV] Refactor vecPolicyOp skip logic in doPeepholeMaskedRVV. NFC

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 02:47:27 PDT 2023


luke added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp:3186
 
+  if (RISCVII::hasVecPolicyOp(MaskedMCID.TSFlags))
+    TailPolicyOpIdx = getVecPolicyOpIdx(N, MaskedMCID);
----------------
frasercrmck wrote:
> I know this is an intermediary patch but I was surprised to see a new check on `RISCVII::hasVecPolicyOp(MaskedMCID.TSFlags)` being introduced just 4 lines above an existing one. Could we move the setting of `TailPolicyOpIdx` into there?
Ah you’re right, that makes much more sense. Will do


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152961/new/

https://reviews.llvm.org/D152961



More information about the llvm-commits mailing list