[PATCH] D152869: [nfc] Factoring out utility that can be used for other object-level tools

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 01:27:01 PDT 2023


jhenderson added a comment.

As there is //currently// only one usage, I don't think a moving of the code benefits anything (you wouldn't do the refactoring if you weren't looking to use it elsewhere, for example). I'm not opposed to the patch being part of a patch series that includes the proposed RFC, but it shouldn't land unless the RFC is accepted and the corresponding patch is still using it once the final version is accepted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152869/new/

https://reviews.llvm.org/D152869



More information about the llvm-commits mailing list