[PATCH] D152241: [CaptureTracking] Do not capture compares of same object

Joshua Cao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 15 00:31:26 PDT 2023


caojoshua added a comment.

> I just realized that my comment on getUnderlyingObject() wasn't right in the following sense: While generally we can't assume that a comparison with the same underlying object is non-capturing, in this particular context, if the value were used in something like ptrmask, we would already report a capture at that point, so it would actually be fine to just use getUnderlyingObject() here.

Yes. Can confirm this with newly added tests. Compare object against ptrmask of itself still does not capture.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152241/new/

https://reviews.llvm.org/D152241



More information about the llvm-commits mailing list