[PATCH] D152431: [Inliner] Handle convergence control when inlining a call

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 20:57:55 PDT 2023


sameerds marked 4 inline comments as done.
sameerds added inline comments.


================
Comment at: llvm/test/Transforms/Inline/convergence-inline.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -passes='cgscc(inline)' -S %s | FileCheck %s
+
----------------
arsenm wrote:
> Pre-commit test with baseline checks
I didn't understand. Without the changes to the inliner, the IR after inlining will fail the verifier in most cases. What would be the value of having such a test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152431/new/

https://reviews.llvm.org/D152431



More information about the llvm-commits mailing list