[PATCH] D152859: [MemorySSA] Always perform MemoryUses liveOnEntry optimization on MSSA construction

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Analysis/MemorySSA.cpp:368
+template <typename AliasAnalysisType>
+static bool isUseTriviallyOptimizableToLiveOnEntry(AliasAnalysisType &AA,
                                                    const Instruction *I) {
----------------
asbirlea wrote:
> Can you check if the the callsite in `optimizeUses` can be removed with this change?
> I think the one in getClobbering needs to stay.
removed, and yeah the one in getClobbering needs to stay when you invalidate an optimized access of a MemoryUse and then try and optimize it again


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:1001
+Expected<bool> parseMemorySSAPrinterPassOptions(StringRef Params) {
+  return parseSinglePassOption(Params, "no-ensure-optimized-uses",
+                               "MemorySSAPrinterPass");
----------------
asbirlea wrote:
> nit: Simpify the test option to "no-optimized-uses".
that's can be misleading because if memoryssa was already optimized previously then it'll still be optimized


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152859/new/

https://reviews.llvm.org/D152859