[PATCH] D152810: [RISCV] Fix IMPLICIT_DEF check in doPeepholeMaskedRVV

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 13:01:39 PDT 2023


reames added a comment.

JFYI, I deleted the undef check in c4a3bd7f <https://reviews.llvm.org/rGc4a3bd7f8b7c587813d0e54d8d2dde7385895d09>.

Also, I'm now 100% convinced the line just above (the policy check) is a miscompile.  It's probably a silent one, but it's definitely a miscompile since we haven't checked whether there are any tail elements (for which agnostic might be undefined).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152810/new/

https://reviews.llvm.org/D152810



More information about the llvm-commits mailing list