[PATCH] D119049: [LLD] Allow usage of LLD as a library

[Leonard Chan via Phabricator via llvm-commits]

leonardchan added a comment.

Hi. This fails for me locally with:

  FAIL: LLD-Unit :: AsLibELF/./LLDAsLibELFTests/0/2 (3 of 2771) 
  ******************** TEST 'LLD-Unit :: AsLibELF/./LLDAsLibELFTests/0/2' FAILED ********************
  Script(shard):
  --
  GTEST_OUTPUT=json:/usr/local/google/home/leonardchan/llvm-monorepo/llvm-build-3-master-fuchsia-toolchain/tools/lld/unittests/AsLibELF/./LLDAsLibELFTests-LLD-Unit-2079095-0-2.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=2 GTEST_SHARD_INDEX=0 /usr/loca
  l/google/home/leonardchan/llvm-monorepo/llvm-build-3-master-fuchsia-toolchain/tools/lld/unittests/AsLibELF/./LLDAsLibELFTests
  --
  
  Script:
  --
  /usr/local/google/home/leonardchan/llvm-monorepo/llvm-build-3-master-fuchsia-toolchain/tools/lld/unittests/AsLibELF/./LLDAsLibELFTests --gtest_filter=AsLib.ROCm
  --
  ld.lld: error: cannot open lld/unittests/AsLibELF/Inputs/kernel1.o: No such file or directory
  Failed to link: lld/unittests/AsLibELF/Inputs/kernel1.o
  lld/unittests/AsLibELF/ROCm.cpp:64: Failure
  Value of: runLinker("%S/Inputs/kernel1.o")
    Actual: false
  Expected: true
  ld.lld: error: cannot open lld/unittests/AsLibELF/Inputs/kernel2.o: No such file or directory
  Failed to link: lld/unittests/AsLibELF/Inputs/kernel2.o
  lld/unittests/AsLibELF/ROCm.cpp:65: Failure
  Value of: runLinker("%S/Inputs/kernel2.o")
    Actual: false
  Expected: true
  ld.lld: error: cannot open lld/unittests/AsLibELF/Inputs/kernel1.o: No such file or directory
  Failed to link: lld/unittests/AsLibELF/Inputs/kernel1.o
  lld/unittests/AsLibELF/ROCm.cpp:66: Failure
  Value of: runLinker("%S/Inputs/kernel1.o")
    Actual: false
  Expected: true
  ld.lld: error: cannot open lld/unittests/AsLibELF/Inputs/kernel2.o: No such file or directory
  Failed to link: lld/unittests/AsLibELF/Inputs/kernel2.o
  lld/unittests/AsLibELF/ROCm.cpp:67: Failure
  Value of: runLinker("%S/Inputs/kernel2.o")
    Actual: false
  Expected: true
  
  lld/unittests/AsLibELF/ROCm.cpp:64
  Value of: runLinker("%S/Inputs/kernel1.o")
    Actual: false
  Expected: true
  lld/unittests/AsLibELF/ROCm.cpp:65
  Value of: runLinker("%S/Inputs/kernel2.o")
    Actual: false
  Expected: true
  lld/unittests/AsLibELF/ROCm.cpp:66
  Value of: runLinker("%S/Inputs/kernel1.o")
    Actual: false
  Expected: true
  lld/unittests/AsLibELF/ROCm.cpp:67
  Value of: runLinker("%S/Inputs/kernel2.o")
    Actual: false
  Expected: true
  
  
  ********************
  ********************
  Failed Tests (1):
    LLD-Unit :: AsLibELF/./LLDAsLibELFTests/AsLib/ROCm

Looks like lld can't find the object files? Could you send out a fix or revert?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119049/new/

https://reviews.llvm.org/D119049