[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

[Alan Phipps via Phabricator via llvm-commits]

alanphipps marked 6 inline comments as done.
alanphipps added inline comments.
Herald added subscribers: hoy, wlei.


================
Comment at: llvm/lib/ProfileData/InstrProfReader.cpp:314
+    uint64_t NumBitmapBytes;
+    if ((Line++)->drop_front(1).getAsInteger(10, NumBitmapBytes))
+      return error(instrprof_error::malformed,
----------------
ellis wrote:
> Why not set `Radix=0` so it can automatically infer the base? Same with the other `getAsInteger()` below. Then the user can specify these values in the most convenient form.
> 
> Also, I'm not sure if `getAsInteger()` will fail if there are spaces. If it does, should we call `.trim()` just before so that we can accept more readable inputs? For example, the tests could look something like this:
> 
> ```
> # Num Bitmask Bytes:
> $ 2
> # Bitmask Byte Values:
> 0x1d
> 0x0
> ```
Hmm I didn't even think of these. Thanks for the suggestions!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138846/new/

https://reviews.llvm.org/D138846