[PATCH] D150388: [CodeGen]Allow targets to use target specific COPY instructions for live range splitting

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 07:27:14 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/InlineSpiller.cpp:830
 
-  bool WasCopy = MI->isCopy();
+  bool WasCopy = TII.isCopyInstr(*MI) ? true : false;
   Register ImpReg;
----------------
yassingh wrote:
> arsenm wrote:
> > Don't need ? true : false
> isCopyInstr() returns std::optional. Should I use 'auto' to get rid of the ternary operator?
or .has_value


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150388/new/

https://reviews.llvm.org/D150388



More information about the llvm-commits mailing list