[PATCH] D152815: [test] Update the checking base for LE and BE
Allen zhong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 14 06:37:12 PDT 2023
Allen marked 2 inline comments as done.
Allen added inline comments.
================
Comment at: llvm/test/CodeGen/AArch64/neon-bitcast.ll:2-3
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=aarch64-none-linux-gnu -mattr=+neon -verify-machineinstrs < %s | FileCheck %s --check-prefix CHECK-LE
+; RUN: llc -mtriple=aarch64_be-none-linux-gnu -mattr=+neon -verify-machineinstrs < %s | FileCheck %s --check-prefix CHECK-BE
----------------
dmgreen wrote:
> Allen wrote:
> > dmgreen wrote:
> > > Maybe use --check-prefixes=CHECK,CHECK-LE and --check-prefixes=CHECK,CHECK-BE, So the common code still reuse the same check lines.
> > Thanks for your idea.
> > I find the **update_llc_test_checks.py** can't generate the checking result with common code automatically,
> > so we should manual maintenance the checking results if we use --check-prefixes=CHECK,CHECK-LE and --check-prefixes=CHECK,CHECK-BE ?
> No - in that case the test is OK as-is. Thanks.
Oh, it does work,thanks.
Since the original cases happened to generate only CHECK, I thought it was invalid.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152815/new/
https://reviews.llvm.org/D152815
More information about the llvm-commits
mailing list