[PATCH] D152701: LowerMemIntrinsics: Check address space aliasing for memmove expansion

[Matt Arsenault via Phabricator via llvm-commits]

arsenm closed this revision.
arsenm marked 2 inline comments as done.
arsenm added a comment.

0696240384cf4b18f65e31d68b51df96c328cb24 <https://reviews.llvm.org/rG0696240384cf4b18f65e31d68b51df96c328cb24>



================
Comment at: llvm/lib/Transforms/Utils/LowerMemIntrinsics.cpp:401-410
+          /* InsertBefore */ InsertBefore,
+          /* SrcAddr */ SrcAddr,
+          /* DstAddr */ DstAddr,
+          /* CopyLen */ CI,
+          /* SrcAlign */ SrcAlign,
+          /* DestAlign */ DstAlign,
+          /* SrcIsVolatile */ SrcIsVolatile,
----------------
tra wrote:
> Nit: The comments matching the variable names don't look particularly useful. I'd remove most of leam, maybe leaving the `CanOverlap`. 
I just copy-pasted from the other place here that does this


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152701/new/

https://reviews.llvm.org/D152701