[PATCH] D152441: [SLPVectorizer] Don't include debug instructions in ScheduleRegionSize

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 02:45:33 PDT 2023


ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:11459
+  auto IsDbgInstr = [](const Instruction &I) {
+                      return isa<DbgInfoIntrinsic>(&I);
+  };
----------------
uabelho wrote:
> ABataev wrote:
> > I think it worth it to extend it not only for debug intrinsics, but for all ephemeral instructions, like lifetime, assume, etc.
> I can do that, e.g. to check isAssumeLikeIntrinsic().
> 
> However, then the patch is starting to drift away from just fixing the "dbg info affects codegen" problem I was aiming at so then we start fixing/changing something else as well.
> 
> Do you still want that in the same patch?
Yes, the change is small, you can do it here. And rename the title.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152441/new/

https://reviews.llvm.org/D152441



More information about the llvm-commits mailing list