[PATCH] D135579: utils/update_mir_test_checks.py: allow checking fixedStack in .mir files

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 14 02:04:27 PDT 2023


foad added a comment.

In D135579#4420335 <https://reviews.llvm.org/D135579#4420335>, @gbossu wrote:

> In D135579#4417921 <https://reviews.llvm.org/D135579#4417921>, @foad wrote:
>
>> This broke regenerating checks for tests like `test/CodeGen/AMDGPU/GlobalISel/regbankselect-amdgcn.s.buffer.load.ll` which use `-simplify-mir` and do not print the `fixedStack` info. Can you fix `update_mir_test_checks` to cope, or should we remove `-simplify-mir` from files with generated checks?
>
> Sorry about this, I'll have a look this week.

No worries. I actually have a simple fix already, I just need to write a test for it. I'll try to put something up for review today.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135579/new/

https://reviews.llvm.org/D135579



More information about the llvm-commits mailing list