[PATCH] D152841: Prevent out of range fixup encoding on AArch64
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 14 01:07:50 PDT 2023
peter.smith added a comment.
Code changes LGTM, if you're aiming for completeness, a test for the pc-relative ldr would also be good.
================
Comment at: llvm/test/MC/AArch64/fixup-out-of-range-edge.s:61
+ tbz x0, #1, tbz_lower_range
+
+// CHECK-LABEL: :{{[0-9]+}}:{{[0-9]+}}: error: fixup value out of range
----------------
The fixup fixup_aarch64_ldr_pcrel_imm19 is also affected. May be worth a test case for that as well. I think that would look like
```
ldr x0, ldr_low_range
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152841/new/
https://reviews.llvm.org/D152841
More information about the llvm-commits
mailing list