[PATCH] D152819: [X86][AMX] Let Store not be removed if combineCastStore failed

[Bing Yu via Phabricator via llvm-commits]

yubing added inline comments.


================
Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:999
     auto *II = cast<IntrinsicInst>(Cast);
     // %43 = call <256 x i32> @llvm.x86.cast.tile.to.vector(x86_amx %42)
     // store <256 x i32> %43, <256 x i32>* %p, align 64
----------------
pengfei wrote:
> Given the condition here, there's no chance return false so far.
but better we align combineCastStore with combineLoadCast. combineCastStore might return false in the future


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152819/new/

https://reviews.llvm.org/D152819