[PATCH] D152869: [nfc] moved SectionFilterIterator for improved reusability

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin accepted this revision.
mtrofin added a comment.
This revision is now accepted and ready to land.

lgtm (some comments)



================
Comment at: llvm/include/llvm/Object/ObjectFile.h:49
 
+typedef std::function<bool(llvm::object::SectionRef const &)> FilterPredicate;
 /// This is a value type class that represents a single relocation in the list
----------------
Since this moves now in the llvm namespace, perhaps renaming it to something less generic, like `SectionFilterPredicate`? By the looks of it, it's only used in the header anyway.

Or move it as a member of `SectionFilterIterator`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152869/new/

https://reviews.llvm.org/D152869