[PATCH] D152147: [RISCV] Fold binary op into select if profitable.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 13 16:52:14 PDT 2023

Previous message: [PATCH] D152147: [RISCV] Fold binary op into select if profitable.
Next message: [PATCH] D152147: [RISCV] Fold binary op into select if profitable.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

craig.topper added a comment.

Please revert. I think the issue is that it never checks the opcode of the binary operator which might not even be a binary operator. It might not even be something that FoldConstantArithmetic can handle.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152147/new/

https://reviews.llvm.org/D152147

Previous message: [PATCH] D152147: [RISCV] Fold binary op into select if profitable.
Next message: [PATCH] D152147: [RISCV] Fold binary op into select if profitable.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list