[PATCH] D152841: Prevent out of range fixup encoding on AArch64

Tue Jun 13 14:08:22 PDT 2023

efriedma added inline comments.

================
Comment at: llvm/test/MC/AArch64/fixup-out-of-range-edge.s:9
+  .word 0
+  .space 1<<20
+  adr x0, adr_lower_range
----------------
MaskRay wrote:
> `.space 1<<20` is 1MiB (acceptable, but best not to introduce too many tests like this) and `.space (1<<27)` below needs 128MiB. The large object file makes test slow and won't work on machines with limited disk space. I'd like to hear from other reviewers.
I get the concern in general, but I don't think this test actually does anything expensive?  It should error out before the point we actually try to expand ".space" to raw bits.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152841/new/

https://reviews.llvm.org/D152841