[PATCH] D151687: [AMDGPU][AsmParser][NFC] Simplify the EndpgmImm operand definition.

Tue Jun 13 11:02:36 PDT 2023

kosarev added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.td:1026
-def EndpgmImm : Operand<i16> {
-  let PrintMethod = "printEndpgm";
-  let ParserMatchClass = EndpgmMatchClass;
----------------
arsenm wrote:
> IIRC endpgm was special to avoid printing it because it's not real and was used for some tooling hack?
Yes, we don't print it when it's 0. I guess it might be useful to keep `s_endpgm` reassemblable when the operand happens to be non-zero, whatever the reason for that might be.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151687/new/

https://reviews.llvm.org/D151687