[PATCH] D146218: [AArch64][CodeGen] Lower (de)interleave2 intrinsics to ld2/st2

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 13 10:33:53 PDT 2023


paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:15214
+
+  Value *BaseAddr = Builder.CreateBitCast(LI->getPointerOperand(), PtrTy);
+  Value *Result;
----------------
paulwalker-arm wrote:
> I thought opaque pointers meant we didn't need to bitcast pointers anymore? I mainly mention it because I wasn't sure what type the following `CreateGEP` call returns and so figured we might either not need any bitcasting or we might need a little more :)
https://www.llvm.org/docs/OpaquePointers.html says that for LLVM 17 "Typed pointers are not supported", so I think the bitcasts can be removed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146218/new/

https://reviews.llvm.org/D146218



More information about the llvm-commits mailing list