[PATCH] D152805: [AMDGPU][GFX11] Add test coverage for 16-bit conversions, part 5.

Ivan Kosarev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 13 10:10:18 PDT 2023


kosarev added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/function-returns.ll:1
-; RUN: llc -march=amdgcn -mtriple=amdgcn-- -mcpu=hawaii -verify-machineinstrs < %s | FileCheck  -enable-var-scope -check-prefixes=GCN,CI %s
-; RUN: llc -march=amdgcn -mtriple=amdgcn-- -mcpu=fiji -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefixes=GCN,GFX89 %s
-; RUN: llc -march=amdgcn -mtriple=amdgcn-- -mcpu=gfx900 -mattr=-flat-for-global -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefixes=GCN,GFX89,GFX9 %s
-
-; GCN-LABEL: {{^}}i1_func_void:
-; GCN: buffer_load_ubyte v0, off
-; GCN-NEXT: s_waitcnt
-; GCN-NEXT: s_setpc_b64
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 2
+; RUN: llc -march=amdgcn -mtriple=amdgcn-- -mcpu=hawaii -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefixes=GCN,GFX789,CI %s
----------------
arsenm wrote:
> Switching to generated checks should be done in a precommit
I don't see how that can be useful in this case. There are no functional changes and the new checks are all as visible here as they would be in a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152805/new/

https://reviews.llvm.org/D152805



More information about the llvm-commits mailing list