[PATCH] D152709: [lit] Avoid os.path.realpath in lit.py due to MAX_PATH limitations on Windows
Tristan Labelle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 13 07:42:04 PDT 2023
MrTrillian added inline comments.
================
Comment at: llvm/utils/lit/lit/discovery.py:59
if config_map:
- cfgpath = os.path.realpath(cfgpath)
- target = config_map.get(os.path.normcase(cfgpath))
+ target = config_map.get(os.path.normcase(os.path.realpath(cfgpath)))
if target:
----------------
rnk wrote:
> I see this uses realpath and that must be intentional.
@rnk The reason was that this is looking up a param from outside the script and I thought it might regress something, but let me try locally if I can convert this and the one in `def search` below as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152709/new/
https://reviews.llvm.org/D152709
More information about the llvm-commits
mailing list