[PATCH] D151996: [AMDGPU] Start documenting calling conventions. NFC

[Diana Picus via Phabricator via llvm-commits]

rovka added inline comments.


================
Comment at: llvm/docs/AMDGPUUsage.rst:1083-1086
+     ``amdgpu_gfx``                  Used for AMD graphics targets. Functions with this calling convention
+                                     cannot be used as entry points.
+                                     ..TODO::
+                                     Describe.
----------------
sebastian-ne wrote:
> For the description: A difference between amdgpu_gfx and the C calling convention is that in amdgpu_gfx, SGPR arguments are callee-save (preserved), in the C cc, they are not.
> Otherwise, there is not much difference.
Surely that's one difference, but I'm not 100% convinced it's the only one. I think we should leave the more detailed description for a future patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151996/new/

https://reviews.llvm.org/D151996