[PATCH] D152794: [AMDGPU][GlobalISel] Shaders can only call amdgpu_gfx

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

> That sounds like an important use case, but maybe a better solution for
> that problem would be to teach llvm-reduce to replace the whole call
> with an undef/null.

No, because that would delete the call entirely which is a much more substantial change.

I'd lean towards just removing this artificial restriction / error altogether before regressing this. Passing undefined inputs seems fine, we could have a lint check for this instead.



================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-call.ll:5295
 
-define amdgpu_ps void @amdgpu_ps_call_default_cc() {
-  ; CHECK-LABEL: name: amdgpu_ps_call_default_cc
----------------
This shouldn't be dropped


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152794/new/

https://reviews.llvm.org/D152794