[PATCH] D152744: [DSE] Don't eagerly optimize MemorySSA uses

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 13 04:05:59 PDT 2023


nikic added a comment.

In D152744#4416847 <https://reviews.llvm.org/D152744#4416847>, @fhahn wrote:

> Looking at the compiler-time tracker link, there are some codegen changes. Do you know where those are coming from and if we could avoid regressions?

I think some codegen changes are expected, because DSE walks over uses, and this will mean that more "irrelevant" uses are visited that count towards the scan limit. The MemorySSAScanLimit is fairly generous at 150 accesses, so it's probably okay in practice, though we could also raise the limit if this causes performance regressions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152744/new/

https://reviews.llvm.org/D152744



More information about the llvm-commits mailing list