[PATCH] D152778: [LoongArch] Ignore warnings when there are no environment in triple
WÁNG Xuěruì via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 13 01:40:22 PDT 2023
xen0n added inline comments.
================
Comment at: llvm/test/CodeGen/LoongArch/target-abi-from-triple-edge-cases.ll:19
+;; Check that no warning is reported for there are no environment component in
+;; triple-supplied ABI modifiers and --target-abi is used.
----------------
grammatical nit: "for there are" -> "when there is"
================
Comment at: llvm/test/CodeGen/LoongArch/target-abi-from-triple-edge-cases.ll:26-27
+
+; NO-WARNING-ILP32D-NOT: warning: triple-implied ABI conflicts with provided target-abi 'ilp32d', using target-abi
+; NO-WARNING-LP64D-NOT: warning: triple-implied ABI conflicts with provided target-abi 'lp64d', using target-abi
+
----------------
Since the intent here is just making sure no warning is emitted, and that the warning's exact form is already checked above, maybe we could coalesce the two into one as simple as `NO-WARNING-NOT: warning`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152778/new/
https://reviews.llvm.org/D152778
More information about the llvm-commits
mailing list