[PATCH] D152758: [NFC] Refactor MBB hotness/coldness into MBFI.

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 19:25:18 PDT 2023


wenlei added a comment.

Thanks for the follow up. It doesn't feel like this belongs to MBFI either. BFI for IR doesn't contain any of the hotness query - instead these are all part of PSI.

I'm wondering if we can make some template functions in PSI that cover both IR and MIR hotness queries, since BFI and MBFI have very similar APIs. We have precedence for PGO code sharing between IR and MIR (`SampleProfileLoaderBaseImpl<BT>`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152758/new/

https://reviews.llvm.org/D152758



More information about the llvm-commits mailing list