[PATCH] D152595: [PseudoProbe] Disgard probes for dead functions.

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

> Currently probes are emitted along with the binary code for functions and the linker is responsible for removing dead code. For probes, the linker can also remove them with the implementation

why do we still have probe for dead functions with this current implementation though?

> Very little.

How much in terms .pseudo_probe section size?

> I'm switching to the implementation D152546 <https://reviews.llvm.org/D152546>: [Pseudo Probe] Placing .pseudoprobe section in a comdat group, which doesn't enable the linker to remove dead probes but has other benefits.

It looks the trade off with the new implementation is that, we would allow ICF for probe section, but would also disable REF when its associated code is being removed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152595/new/

https://reviews.llvm.org/D152595