[PATCH] D89049: [AIX][XCOFF] print out the traceback info

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objdump/XCOFFDump.cpp:165
+      if (support::endian::read32be(Bytes.slice(I, 4).data()) != 0)
+        LastNonZero = (I + 4) > Size ? Size : (I + 4);
+    }
----------------
We don't usually add parens for `(A + B) > C` and `... ? : A + B`.


================
Comment at: llvm/tools/llvm-objdump/XCOFFDump.cpp:175
+      Index += 4;
+      WarningStream << "\n";
+    }
----------------
Nit: here and throughout, you can use `'\n'` as it compiles to less machine code and is slightly faster.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89049/new/

https://reviews.llvm.org/D89049