[PATCH] D150276: [llvm-objcopy] -O binary: do not align physical addresses

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

Your commit message has 4-space indentation. Please remove that. `git log -1 --pretty=%B` messages don't usually have indentation.

This issue causes the Differential summary to be rendered like a Markdown code block.

> https://github.com/llvm/llvm-project/issues/62636

`Fix https://github.com/llvm/llvm-project/issues/62636`



================
Comment at: llvm/test/tools/llvm-objcopy/ELF/binary-paddr.test:292
+    VAddr:           0x400000
+    PAddr:           0x200014
+    Align:           0x1000
----------------
Add a comment.

`## PAddr is not aligned by sh_addralign(.data).`


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/binary-paddr.test:309
+    Content:         BDACCDAB
+Symbols:
+  - Name:            INIT_DATA_START
----------------
Delete the symbols. They are unrelated to the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150276/new/

https://reviews.llvm.org/D150276