[PATCH] D152766: AMDGPU: Use correct lowering for llvm.log2.f32

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 18:32:36 PDT 2023


arsenm created this revision.
arsenm added reviewers: AMDGPU, foad, rampitec, Pierre-vh, cdevadas.
Herald added subscribers: StephenFan, jdoerfert, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

We previously directly codegened to v_log_f32, which is broken for
denormals. The lowering isn't complicated, you simply need to scale
denormal inputs and adjust the result.


https://reviews.llvm.org/D152766

Files:
  llvm/docs/AMDGPUUsage.rst
  llvm/docs/LangRef.rst
  llvm/docs/ReleaseNotes.rst
  llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
  llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h
  llvm/lib/Target/AMDGPU/AMDGPUInstrInfo.td
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/test/CodeGen/AMDGPU/GlobalISel/fpow.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-flog.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-flog10.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-flog2.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fpow.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fpowi.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.powi.ll
  llvm/test/CodeGen/AMDGPU/llvm.log.ll
  llvm/test/CodeGen/AMDGPU/llvm.log10.ll
  llvm/test/CodeGen/AMDGPU/llvm.log2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152766.530742.patch
Type: text/x-patch
Size: 372231 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230613/244f8089/attachment-0001.bin>


More information about the llvm-commits mailing list